Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/framework: Try to override dynamic package enables #10623

Merged
merged 1 commit into from
Jun 16, 2022
Merged

packages/framework: Try to override dynamic package enables #10623

merged 1 commit into from
Jun 16, 2022

Conversation

e10harvey
Copy link
Contributor

@e10harvey e10harvey commented Jun 15, 2022 •
edited
Loading

@trilinos/framework

Motivation

The new Trilinos_PR_python3 build is not overriding the dynamic set of package enables causing mass PR failures as reported in #10622.

#10622 and everyone with PRs touching anything outside of packages/framework

Stakeholder Feedback

Testing

Replaying the failing pipeline reported via https://trilinos-cdash.sandia.gov/index.php?project=Trilinos&parentid=183234&filtercount=1&showfilters=1&field1=buildstarttime&compare1=84&value1=NOW&filtercombine=and with these changes on top of the #10614 source branch. Here are those pipeline results on cdash.

@e10harvey e10harvey added type: bug The primary issue is a bug in Trilinos code or tests PA: Framework Issues that fall under the Trilinos Framework Product Area labels Jun 15, 2022
@e10harvey e10harvey requested review from bartlettroscoe and a team June 15, 2022 16:36
@e10harvey e10harvey self-assigned this Jun 15, 2022
@e10harvey e10harvey added AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed and removed AT: WIP Causes the PR autotester to not test the PR. (Remove to allow testing to occur.) labels Jun 15, 2022
@e10harvey
Copy link
Contributor Author

Once this merges, the rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework should start passing again in your PR tests. Apologies for the confusion and PR test failure noise.

CC: @kyungjoo-kim, @ndellingwood, @bartlettroscoe, @rppawlo, @trilinos/framework

bartlettroscoe
bartlettroscoe approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how GenConfig works here but if this passes the PR builds, great!

Someone on the framework team that knows GenConfig should review this though

@e10harvey
Copy link
Contributor Author

Someone on the framework team that knows GenConfig should review this though

@jwillenbring, please review when you have time.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 162
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 166
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 164
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 169
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 166
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 185
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 54
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Using Repos:

Repo: TRILINOS (e10harvey/Trilinos)
  • Branch: issue10622
  • SHA: 6575b12
  • Mode: TEST_REPO

Pull Request Author: e10harvey

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 162
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-serial

  • Build Num: 166
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_gcc-7.2.0-debug

  • Build Num: 164
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_intel-17.0.1

  • Build Num: 169
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-17.0.1-mpich-3.2-serial_release-debug_static_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_clang-10.0.0

  • Build Num: 166
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-10.0.0-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_cuda-10.1.243

  • Build Num: 185
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME ats2_cuda-10.1.243-gnu-8.3.1-spmpi-rolling_release_static_Volta70_Power9_no-asan_no-complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL vortex
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 54
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS type: bug;AT: AUTOMERGE;PA: Framework
PULLREQUESTNUM 10623
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_BRANCH issue10622
TRILINOS_SOURCE_REPO https://github.com/e10harvey/Trilinos
TRILINOS_SOURCE_SHA 6575b12
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 74224c5


CDash Test Results for PR# 10623.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit af47f04 into trilinos:develop Jun 16, 2022
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 10623: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jun 16, 2022
@e10harvey e10harvey mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

Assignees

@e10harvey e10harvey

Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e10harvey @trilinos-autotester @bartlettroscoe