Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the achievedTol interface for the GmresPolySolMgr #10435

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

hkthorn
Copy link
Contributor

@hkthorn hkthorn commented Apr 13, 2022

@trilinos/belos

Motivation

A user request has been received for the Gmres polynomial preconditioned
solver to return the achieved tolerance from the outer iterative method.
This is best done through the achievedTol() method in the abstract solver
manager interface, that is utilized by most of the iterative methods.
This commit implements that function call and includes a test of that call
to ensure it works.

Stakeholder Feedback

Testing

OSX GCC11 Serial

A user request has been received for the Gmres polynomial preconditioned
solver to return the achieved tolerance from the outer iterative method.
This is best done through the achievedTol() method in the abstract solver
manager interface, that is utilized by most of the iterative methods.
This commit implements that function call and includes a test of that call
to ensure it works.
@hkthorn hkthorn added pkg: Belos AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Apr 13, 2022
@hkthorn hkthorn requested a review from jennloe April 13, 2022 18:12
@hkthorn hkthorn self-assigned this Apr 13, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@jennloe jennloe added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 13, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 13, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@jennloe jennloe added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 15, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 15, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@jennloe
Copy link
Contributor

jennloe commented Apr 15, 2022

@trilinos/framework Seems problems with the autotester are holding this up? Along with other PRs?

@e10harvey
Copy link
Contributor

@trilinos/framework Seems problems with the autotester are holding this up? Along with other PRs?

Yes. Please see #10428.

@ZUUL42 ZUUL42 added the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 24, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 7413
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4909
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 5428
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 12458
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 5160
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: python-3

  • Build Num: 1721
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 829
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Using Repos:

Repo: TRILINOS (hkthorn/Trilinos)
  • Branch: develop
  • SHA: 19c3699
  • Mode: TEST_REPO

Pull Request Author: hkthorn

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 7413
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4909
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 5428
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 12458
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 5160
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: python-3

  • Build Num: 1721
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 829
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10435
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH develop
TRILINOS_SOURCE_REPO https://github.com/hkthorn/Trilinos
TRILINOS_SOURCE_SHA 19c3699
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0


CDash Test Results for PR# 10435.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 25, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jennloe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit f79e62d into trilinos:develop Apr 25, 2022
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 10435: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants