Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piro: Create a Forward Only Tempus Solver #10226

Merged

Conversation

ccober6
Copy link
Contributor

@ccober6 ccober6 commented Feb 21, 2022

An application requires a forward only version of TempusSolver. We
will derive it from RythmosSolver and replace Rythmos calls with
Tempus calls. Removed all the Rythmos solver portions and the
sensitivities are not needed.

@trilinos/piro
@trilinos/tempus

Motivation

Help application move from Rythmos to Tempus.

Related Issues

Stakeholder Feedback

Stakeholder will test this feature in their application.

Testing

Added unit tests covering the basic usage.

An application requires a forward only version of TempusSolver. We
will derive it from RythmosSolver and replace Rythmos calls with
Tempus calls.  Removed all the Rythmos solver portions and the
sensitivities are not needed.
@ccober6 ccober6 added type: enhancement Issue is an enhancement, not a bug pkg: Piro pkg: Tempus labels Feb 21, 2022
@ccober6 ccober6 requested a review from rppawlo February 21, 2022 22:48
@ccober6 ccober6 self-assigned this Feb 21, 2022
@ccober6
Copy link
Contributor Author

ccober6 commented Feb 21, 2022

@glhenni Here is what we have so far. From here we should match up the ParameterLists and Observers as needed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_clang_10.0.0 to start: Total Wait = 603

@ccober6 ccober6 added AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration labels Feb 22, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 6739
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4257
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 4777
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11856
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 4617
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: python-3

  • Build Num: 1180
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 391
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: 10225-Piro-Create-a-Forward-Only-Tempus-Solver
  • SHA: 07e5041
  • Mode: TEST_REPO

Pull Request Author: ccober6

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 6739
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4257
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 4777
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 11856
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 4617
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: python-3

  • Build Num: 1180
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 391
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS type: enhancement;pkg: Piro;pkg: Tempus;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10226
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH 10225-Piro-Create-a-Forward-Only-Tempus-Solver
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA 07e5041
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA a993797


CDash Test Results for PR# 10226.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Feb 22, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ rppawlo ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit a82d667 into develop Feb 23, 2022
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 10226: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Feb 23, 2022
@ccober6 ccober6 deleted the 10225-Piro-Create-a-Forward-Only-Tempus-Solver branch February 23, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Piro pkg: Tempus type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants