Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Belos: issue causing segfault when output requested #9522

Closed
skennon10 opened this issue Aug 4, 2021 · 3 comments
Closed

Belos: issue causing segfault when output requested #9522

skennon10 opened this issue Aug 4, 2021 · 3 comments
Assignees
@jennloe
Labels
pkg: Belos type: bug The primary issue is a bug in Trilinos code or tests

Comments

@skennon10
Copy link
Contributor

This line sets "Output Style" to verbosity_ instead of outputStyle_:

Trilinos/packages/belos/src/BelosPseudoBlockGmresSolMgr.hpp

Line 711 in 53ecba4

params_->set ("Output Style", verbosity_);

For my case using this solver, verbosity_ = 41, and it causes a segfault here since StatusTestOutputFactory::create has no "default" clause in the switch statement and returns a null RCP:

Trilinos/packages/belos/src/BelosPseudoBlockGmresSolMgr.hpp

Line 1184 in 53ecba4

outputTest_->setSolverDesc( solverDesc );

@jhux2 jhux2 added pkg: Belos type: bug The primary issue is a bug in Trilinos code or tests labels Aug 4, 2021
@jhux2
Copy link
Member

jhux2 commented Aug 4, 2021

@trilinos/belos

@jennloe
Copy link
Contributor

jennloe commented Aug 6, 2021

I'll look at this.

@jennloe jennloe self-assigned this Aug 6, 2021
jennloe added a commit to jennloe/Trilinos that referenced this issue Aug 9, 2021
@jennloe
Belos: Fix for output style crash. Issue trilinos#9522.
4a17a64
@jennloe jennloe mentioned this issue Aug 9, 2021
Merged
trilinos-autotester added a commit that referenced this issue Aug 10, 2021
@trilinos-autotester
Merge Pull Request #9539 from jennloe/Trilinos/Fix9522
0e429a5 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Belos: Fix Output Style Crash, Issue #9522
PR Author: jennloe
@jennloe
Copy link
Contributor

jennloe commented Aug 10, 2021

Closed by PR #9539.

@jennloe jennloe closed this as completed Aug 10, 2021
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Aug 11, 2021
Merge 'trilinos/Trilinos:develop' (25b2748) into 'tcad-charon/Trilino…
04e3d23 
…s:develop' (ed13b3a).

* trilinos-develop: (23 commits)
  Zoltan2 HIP: address comments by Karen and Jonathan
  This just changes the python job name to match the jenkins job
  Panzer: remove uvm from point values
  MueLu/Ifpack2/Tpetra: Adding Reitzinger / Hiptmair support / Fixing SpGEMM bug (trilinos#9526)
  MOdified test:
  have functor working in uvm
  STK: Snapshot 08-09-21 12:15
  Belos: Fix for output style crash.  Issue trilinos#9522.
  Allow use of python > 3,8
  Change path to source common.sh to the new location
  Revert "Remove unset of PYTHONPATH"
  Remove unset of PYTHONPATH
  Rename python unit tests under commonTools to "old"
  Final *ini files for the jenkins jobs.
  Change import paths to match recent updates
  Fixing some comments for consistency
  Zoltan2: small modifications for HIP
  Add load of anaconda3.7 and set variables to match
  Correct typo and missing option
  Use the genconfig build name for the load-env call and for CDash
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Aug 12, 2021
Merge 'trilinos/Trilinos:develop' (7fb5173) into 'tcad-charon/Trilino…
444dcfa 
…s:develop' (ed13b3a).

* trilinos-develop: (39 commits)
  MueLu: fix misleading indentation in unit test
  Remove UVM from PanzerAdaptersSTK (partially) (trilinos#9550)
  Fixed poinrfield test for UVM
  MueLu: update details of bibliographic reference
  Added the label to the png
  Update README.md
  Better way of determing what file system to use
  Sovles issues where on Linux systems file where error is thown rather than save file
  Zoltan2 HIP: address comments by Karen and Jonathan
  This just changes the python job name to match the jenkins job
  Panzer: remove uvm from point values
  MueLu/Ifpack2/Tpetra: Adding Reitzinger / Hiptmair support / Fixing SpGEMM bug (trilinos#9526)
  MOdified test:
  have functor working in uvm
  Small fix and added some error handling
  STK: Snapshot 08-09-21 12:15
  Belos: Fix for output style crash.  Issue trilinos#9522.
  Made code more organized by adding a function
  removed dead code
  MergeLevelGraphs.__renameSubgraphs is now O(n)
  ...
PhilMiller pushed a commit to PhilMiller/Trilinos that referenced this issue Dec 22, 2021
Merge 'trilinos/Trilinos:develop' (7fb5173) into 'EM-Plasma/Trilinos:…
c6d128f 
…develop' (47dab76).

* trilinos/develop: (50 commits)
  MueLu: fix misleading indentation in unit test
  Remove UVM from PanzerAdaptersSTK (partially) (trilinos#9550)
  Fixed poinrfield test for UVM
  MueLu: update details of bibliographic reference
  Added the label to the png
  Update README.md
  Better way of determing what file system to use
  Sovles issues where on Linux systems file where error is thown rather than save file
  Zoltan2 HIP: address comments by Karen and Jonathan
  This just changes the python job name to match the jenkins job
  Panzer: remove uvm from point values
  MueLu/Ifpack2/Tpetra: Adding Reitzinger / Hiptmair support / Fixing SpGEMM bug (trilinos#9526)
  MOdified test:
  have functor working in uvm
  Small fix and added some error handling
  Fixed normals test
  STK: Snapshot 08-09-21 12:15
  Fixed local mesh computation for UVM
  Belos: Fix for output style crash.  Issue trilinos#9522.
  Made code more organized by adding a function
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennloe jennloe

Labels
pkg: Belos type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhux2 @skennon10 @jennloe