Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: add methods to CrsMatrix to replace Domain / Range maps #9451

Closed
kddevin opened this issue Jul 19, 2021 · 0 comments
Closed

Tpetra: add methods to CrsMatrix to replace Domain / Range maps #9451

kddevin opened this issue Jul 19, 2021 · 0 comments
Assignees
@kddevin
Labels
pkg: Tpetra type: enhancement Issue is an enhancement, not a bug UVM removal

Comments

@kddevin
Copy link
Contributor

kddevin commented Jul 19, 2021

Enhancement

@trilinos/tpetra

Add CrsMatrix methods that enable replacement of domain and range maps (and, optionally, importer and exporters).
Method replaceDomainMapAndImporter exists, but there is no way to replace just the domain map (and have the importer computed by Tpetra) or to replace the range map.

Need for these functions was identified in the use case for #9391.

When done, replace the fix for #9391 with shallow copy constructor followed by replaceDomainMap, replaceRangeMap.
@kddevin kddevin added type: enhancement Issue is an enhancement, not a bug pkg: Tpetra UVM removal labels Jul 19, 2021
@kddevin kddevin self-assigned this Jul 19, 2021
@kddevin kddevin mentioned this issue Jul 19, 2021
Closed
kddevin added a commit that referenced this issue Aug 27, 2021
@kddevin
tpetra: added method replaceDomainMap for #9451; fixed doxygen
5c4b6a0 
comments for replaceDomainMapAndImport to match the error checks in code
@kddevin kddevin mentioned this issue Aug 27, 2021
Merged
kddevin added a commit that referenced this issue Aug 30, 2021
@kddevin
tpetra: revisions to address @Tasmit's review of #9451
9f916b6
kddevin added a commit that referenced this issue Sep 7, 2021
@kddevin
Tpetra: added methods to replace Domain and Range maps in CrsMatrix a…
cece41b 
…nd CrsGraph (#9626)

* tpetra:  added method replaceDomainMap for #9451; fixed doxygen
comments for replaceDomainMapAndImport to match the error checks in code

* tpetra:  put re-used code into a macro

* tpetra:  new functions and test:  replaceRangeMap, replaceRangeMapAndExporter

* tpetra: Minor

* tpetra:  revisions to address @Tasmit's review of #9451
@kddevin kddevin closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kddevin kddevin

Labels
pkg: Tpetra type: enhancement Issue is an enhancement, not a bug UVM removal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kddevin