-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xpetra: issue with MultiVector::getLocalView in uvm_off build #9146
Comments
@jewatkins Yes, we are planning to rewrite parts of Xpetra to use Tpetra's new interfaces. If you can work around this, that might be better for the moment, but leaving this issue open as a reminder that we need to revisit this. Would that be ok with you? @trilinos/xpetra |
Yes, I think that's okay for now. Let me see if the work around works for all cases. |
- temporary fix for trilinos#9146
Not sure why we're building Xpetra/MueLu in that PR build at all. |
This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity. |
Xpetra multivector has been updated and I don't currently see any issues with what's currently being used so I think we can close this. |
Bug Report
@trilinos/xpetra
Description
The uvm_off build is broken in PR #9107 because of the use of Xpetra::MultiVector::getLocalView(). See: https://testing.sandia.gov/cdash/viewBuildError.php?buildid=9186703
There's some logic there that I don't think works for cuda space. Is someone planning to work on this soon? I imagine the fix would be similar to what's done in Tpetra.
I'm able to get passed this issue by specifically calling getDeviceLocalView() but it's probably better to fix getLocalView().
Steps to Reproduce
Build the uvm_off build with https://github.com/jewatkins/Trilinos/tree/jewatkins/muelu-semicoarsen-kokkos
The text was updated successfully, but these errors were encountered: