Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: error when calling ReuseTpetraPreconditioner #7411

Closed
jhux2 opened this issue May 21, 2020 · 4 comments
Closed

MueLu: error when calling ReuseTpetraPreconditioner #7411

jhux2 opened this issue May 21, 2020 · 4 comments
Assignees
@jhux2
Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests

Comments

@jhux2
Copy link
Member

jhux2 commented May 21, 2020 •
edited
Loading

A number of users have reported that when using ReuseTpetraPreconditioner, the resulting Hierarchy::apply() crashes on the second go-round.
@jhux2 jhux2 added type: bug The primary issue is a bug in Trilinos code or tests pkg: MueLu labels May 21, 2020
@jhux2 jhux2 self-assigned this May 21, 2020
@jhux2
Copy link
Member Author

jhux2 commented May 21, 2020

I have a unit test that reproduces this.

jhux2 added a commit that referenced this issue May 27, 2020
@jhux2
MueLu: fix issue #7411
d22cdc7
@jhux2 jhux2 mentioned this issue May 27, 2020
Merged
jhux2 added a commit that referenced this issue May 27, 2020
@jhux2
MueLu: remove out-dated comment
d10c2fb 
Related to issue #7411.
@jhux2
Copy link
Member Author

jhux2 commented May 27, 2020

@vbrunini @rcknaus

@jhux2
Copy link
Member Author

jhux2 commented May 27, 2020

The PR that fixes this is now in Trilinos/develop. Please let me know whether this fixes the problem for you.

@vbrunini
Copy link
Contributor

Confirmed that this fixes the problem for both of our test cases.

jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue May 28, 2020
Merge 'trilinos/Trilinos:develop' (afca7ce) into 'tcad-charon/Trilino…
8f23034 
…s:develop' (f96bb4d).

* trilinos-develop:
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Update all solver managers to use the OrthoFactory.
  TrilinosCouplings:  Fix uninitialized variable use in many examples.
  Sacado:  Make the new Fad design the default.
@jhux2 jhux2 closed this as completed May 29, 2020
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue May 29, 2020
Merge 'trilinos/Trilinos:develop' (42ec188) into 'tcad-charon/Trilino…
7968534 
…s:develop' (f96bb4d).

* trilinos-develop: (32 commits)
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Print return value for jsrun and some reformatting (trilinos#7211)
  ATDM: ats2: Purge then load StdEnv (ATDV-351)
  ATDM: ats2: Update to use patchec cmake 3.17.2 and CTest GPU allocation (ATDV-333)
  ATDM: ats2: Only load on sparc-dev module, other cleanup (ATDV-351)
  ATDM: ats2: Make 'rolling' uppercase in ATDM_CONFIG_COMPILER (ATDM-351)
  ATDM: ats2: Switch to atdm_match_any_buildname_keyword (ATDV-351)
  ATDM: ats2: Add unit tests for custom_builds.sh (ATDV-351)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue May 30, 2020
Merge 'trilinos/Trilinos:develop' (b0ec091) into 'tcad-charon/Trilino…
1df2350 
…s:develop' (f96bb4d).

* trilinos-develop: (36 commits)
  Fixes calls to normalize zero vectors in ICGS/IMGS (trilinos#7454)
  Tacho - remove valgrind error
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Print return value for jsrun and some reformatting (trilinos#7211)
  ATDM: ats2: Purge then load StdEnv (ATDV-351)
  ATDM: ats2: Update to use patchec cmake 3.17.2 and CTest GPU allocation (ATDV-333)
  ATDM: ats2: Only load on sparc-dev module, other cleanup (ATDV-351)
  ATDM: ats2: Make 'rolling' uppercase in ATDM_CONFIG_COMPILER (ATDM-351)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue May 31, 2020
Merge 'trilinos/Trilinos:develop' (7ed2016) into 'tcad-charon/Trilino…
3c1fa33 
…s:develop' (f96bb4d).

* trilinos-develop: (57 commits)
  Fixes calls to normalize zero vectors in ICGS/IMGS (trilinos#7454)
  ATDM: ats2: Elevate complex build to 'Specialized' for now (ATDV-300)
  Amesos2: Fix Epetra crash for SuperLU
  ATDM: ats2: Add cuda-complex build to support GEMMA (ATDV-300)
  Tacho - remove valgrind error
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  Amesos2: Fix sign compare warning for SuperLU
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Print return value for jsrun and some reformatting (trilinos#7211)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 1, 2020
Merge 'trilinos/Trilinos:develop' (7ed2016) into 'tcad-charon/Trilino…
6f4d146 
…s:develop' (f96bb4d).

* trilinos-develop: (57 commits)
  Fixes calls to normalize zero vectors in ICGS/IMGS (trilinos#7454)
  ATDM: ats2: Elevate complex build to 'Specialized' for now (ATDV-300)
  Amesos2: Fix Epetra crash for SuperLU
  ATDM: ats2: Add cuda-complex build to support GEMMA (ATDV-300)
  Tacho - remove valgrind error
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  Amesos2: Fix sign compare warning for SuperLU
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Print return value for jsrun and some reformatting (trilinos#7211)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 2, 2020
Merge 'trilinos/Trilinos:develop' (7ed2016) into 'tcad-charon/Trilino…
340f5f0 
…s:develop' (f96bb4d).

* trilinos-develop: (57 commits)
  Fixes calls to normalize zero vectors in ICGS/IMGS (trilinos#7454)
  ATDM: ats2: Elevate complex build to 'Specialized' for now (ATDV-300)
  Amesos2: Fix Epetra crash for SuperLU
  ATDM: ats2: Add cuda-complex build to support GEMMA (ATDV-300)
  Tacho - remove valgrind error
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  Amesos2: Fix sign compare warning for SuperLU
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  Print return value for jsrun and some reformatting (trilinos#7211)
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jun 3, 2020
Merge 'trilinos/Trilinos:develop' (201bed2) into 'tcad-charon/Trilino…
c735320 
…s:develop' (f96bb4d).

* trilinos-develop: (58 commits)
  Piro: bug fix required for transient forward sensitivities to work in Albany and extension of observer to observe dx/dp (trilinos#7456)
  Fixes calls to normalize zero vectors in ICGS/IMGS (trilinos#7454)
  ATDM: ats2: Elevate complex build to 'Specialized' for now (ATDV-300)
  Amesos2: Fix Epetra crash for SuperLU
  ATDM: ats2: Add cuda-complex build to support GEMMA (ATDV-300)
  Tacho - remove valgrind error
  ATDM: Kokkos now likes upper-case arch names (trilinos#7247)
  ATDM: Make KOKKOS_ARCH looping work with commas (trilinos#7247)
  ATDM: Add some comments for clues on how to use (trilinos#7247)
  Update KOKKOS_ARCH settings to Kokkos_ARCH_arch=ON
  Summary:
  MiniTensor: Sierra/SM tolerance changes.
  MueLu: skip test for SC=complex
  ATDM: ats1: Promote all to 'Specialized' (ATDV-355)
  MueLu: remove out-dated comment
  Amesos2: Fix sign compare warning for SuperLU
  ATDM: ats1: Remove ATDM_CONFIG_Kokkos_ENABLE_SERIAL=OFF (trilinos#7435)
  ATDM: Add unset ATDM_CONFIG_Kokkos_ENABLE_SERIAL and cleanup some unused (trilinos#7435)
  MueLu: fix issue trilinos#7411
  Add ortho option to Epetra Gmres ex for testing.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhux2 jhux2

Labels
pkg: MueLu type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbrunini @jhux2