Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intrepid2: Remove problematic deprecation macros #7070

Closed
CamelliaDPG opened this issue Mar 23, 2020 · 0 comments
Closed

Intrepid2: Remove problematic deprecation macros #7070

CamelliaDPG opened this issue Mar 23, 2020 · 0 comments
Assignees
@CamelliaDPG
Labels
type: enhancement Issue is an enhancement, not a bug

Comments

@CamelliaDPG
Copy link
Contributor

Code Cleanup

@trilinos/intrepid2

As discussed in #7059, there are compilers/architectures that don't play nicely with the typedef deprecation warning macros added to Intrepid2 a while ago. As also noted there, the typedefs we were warning about aren't actually in use any longer, as of last week. This issue is to remove those macros, to avoid the temptation to use them again.
@CamelliaDPG CamelliaDPG added the type: enhancement Issue is an enhancement, not a bug label Mar 23, 2020
@CamelliaDPG CamelliaDPG self-assigned this Mar 23, 2020
mperego added a commit to mperego/Trilinos that referenced this issue Jul 8, 2020
@mperego
Intrepid2: Remove deprecation mascros (issue trilinos#7070)
58e2498
@mperego mperego mentioned this issue Jul 8, 2020
Merged
trilinos-autotester added a commit that referenced this issue Jul 9, 2020
@trilinos-autotester
Merge Pull Request #7653 from mperego/Trilinos/develop
5df9734 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Intrepid2: Remove deprecation macros (issue #7070)
PR Author: mperego
@mperego mperego closed this as completed Jul 9, 2020
@mperego mperego mentioned this issue Jul 9, 2020
Closed
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jul 10, 2020
Merge 'trilinos/Trilinos:develop' (996ebb2) into 'tcad-charon/Trilino…
7641a28 
…s:develop' (7cb81d9).

* trilinos-develop:
  Tempus: fix SSPERK54 bug and add error estimator
  Put pack the LD_LIBRARY_PATH to fix intel-18 test failures (ATDV-272)
  Intrepid2: Remove deprecation mascros (issue trilinos#7070)
  tpetra:  removing computation of unused fields lowerTriangular_, upperTriangular_, nodeNumDiags_, globalNumDiags_ for trilinos#7446, trilinos#2630, trilinos#2658
  Add if guard KOKKOS_ENABLE_CUDA_UVM
  Change COMPLEX to ADELUS_COMPLEX
  Add specialization for UVM
  Amesos2: Clean up Basker type handling
  Amesos2: Refactor Basker to use Kokkos views
  Use cuda host pinned memory for MPI_Irecv/MPI_Send
  Remove copy in solve and do some cleanups
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Jul 10, 2020
Merge 'trilinos/Trilinos:develop' (996ebb2) into 'tcad-charon/Trilino…
6a142f4 
…s:develop' (7cb81d9).

* trilinos-develop:
  Tempus: fix SSPERK54 bug and add error estimator
  Put pack the LD_LIBRARY_PATH to fix intel-18 test failures (ATDV-272)
  Intrepid2: Remove deprecation mascros (issue trilinos#7070)
  tpetra:  removing computation of unused fields lowerTriangular_, upperTriangular_, nodeNumDiags_, globalNumDiags_ for trilinos#7446, trilinos#2630, trilinos#2658
  Add if guard KOKKOS_ENABLE_CUDA_UVM
  Change COMPLEX to ADELUS_COMPLEX
  Add specialization for UVM
  Amesos2: Clean up Basker type handling
  Amesos2: Refactor Basker to use Kokkos views
  Use cuda host pinned memory for MPI_Irecv/MPI_Send
  Remove copy in solve and do some cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CamelliaDPG CamelliaDPG

Labels
type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CamelliaDPG @mperego