Question: ATDM build type "release-debug" doesn't correspond to CMAKE_BUILD_TYPE "RELWITHDEBINFO"

[jhux2]

@bartlettroscoe @trilinos/framework

I would like to set the build type to be optimized with debug symbols with the script Trilinos/cmake/std/atdm/load-env.sh. Here's what I tried:

source ${TRILINOS_DIR}/cmake/std/atdm/load-env.sh sems-rhel6-clang-release-debug-serial
ARGS=(
  -GNinja
  -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake
  -DTrilinos_ENABLE_TESTS=OFF
  -DTrilinos_ENABLE_Galeri=ON
  -DTrilinos_ENABLE_MueLu=ON
    -DMueLu_ENABLE_TESTS=ON
    -DMueLu_ENABLE_EXAMPLES=OFF
)
cmake "${ARGS[@]}" ${TRILINOS_DIR}

I would expect that Trilinos configure would report CMAKE_BUILD_TYPE as RELWITHDEBINFO, but it reports RELEASE instead.

The following works as expected:
source ${TRILINOS_DIR}/cmake/std/atdm/load-env.sh sems-rhel6-clang-release-serial
Trilinos configure reports CMAKE_BUILD_TYPE as RELEASE

source ${TRILINOS_DIR}/cmake/std/atdm/load-env.sh sems-rhel6-clang-debug-serial
Trilinos configure reports CMAKE_BUILD_TYPE as DEBUG.

Am I doing something wrong?

[jhux2]

Here is the result of the command source ${TRILINOS_DIR}/cmake/std/atdm/load-env.sh sems-rhel6-clang-release-debug-serial:

Hostname 'cee-build014' matches known ATDM host 'sems-rhel6' and system 'sems-rhel6'
Setting compiler and build options for build-name 'sems-rhel6-clang-release-debug-serial'
Using SEMS RHEL6 compiler stack CLANG-3.9.0 to build RELEASE-DEBUG code with Kokkos node type SERIAL

[jhux2]

Btw, using the cmake option -DCMAKE_BUILD_TYPE=RELWITHDEBINFO causes the build to do the right thing, i.e., optimized + -g.

[bartlettroscoe]

@jhux2, I think this may be a feature request and this is a subtle issue. As explained at:

• https://github.com/trilinos/Trilinos/blob/develop/cmake/std/atdm/README.md#release_debug

using release-debug does indeed set CMAKE_BULD_TYPE=RELEASE and Trilinos_ENABLE_DEBUG=ON. Therefore, this does not actually increase the size of the executable much. Adding -g will increase the size of the executable. But I guess the runtime error messages are less useful when missing debug info.

I guess we could change the ATDM Trilinos configuration such that adding release-debug set CMAKE_BULD_TYPE=RELWITHDEBINFO and Trilinos_ENABLE_DEBUG=ON. Given that full debug builds are run on many of these systems (which definitely set -g), this should be pretty safe.

[bartlettroscoe]

@jhux2, I added this to the backlog in #6023.

[jhux2]

I think this may be a feature request and this is a subtle issue.
using release-debug does indeed set CMAKE_BULD_TYPE=RELEASE and Trilinos_ENABLE_DEBUG=ON. Therefore, this does not actually increase the size of the executable much. Adding -g will increase the size of the executable. But I guess the runtime error messages are less useful when missing debug info.

@bartlettroscoe Thanks for the explanation. I have work around, so this isn't blocking my work. I will update the title to make it easier to search on.

[bartlettroscoe]

@jhux2, since this triggered a feature request in #6023, I will go head and close this issue.

Thanks for reporting issues like this!

[bartlettroscoe]

Closing this issue now that #6023 is created.