Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATDM: Add a release-debug build that adds debug symbols #6023

Closed
bartlettroscoe opened this issue Oct 2, 2019 · 4 comments
Closed

ATDM: Add a release-debug build that adds debug symbols #6023

bartlettroscoe opened this issue Oct 2, 2019 · 4 comments
Labels
ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug

Comments

@bartlettroscoe
Copy link
Member

It was required in #6022 that the release-debug keyword in that ATDM Trilinos build name set CMAKE_BULD_TYPE=RELWITHDEBINFO instead of CMAKE_BULD_TYPE=RELEASE so that -g will get set. his will increase the size of the executables (perhaps but a lot) with the addition of -g but no more than a pure debug build which sets CMAKE_BUILD_TYPE=DEBUG. And you need debug symbol info to make the runtime error messages generated from the runtime error checks enabled by Trilinos_ENABLE_DEBUG=ON to be more useful (like in stack traces).

@bartlettroscoe bartlettroscoe added type: enhancement Issue is an enhancement, not a bug client: ATDM Any issue primarily impacting the ATDM project ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams labels Oct 2, 2019
@bartlettroscoe
Copy link
Member Author

@jhux2,

After some more thought, given that this change will make release-debug will increase the binary size a lot over just release, it might be better to introduce the new keywords relwithdebinfo and relwithdebinfo-debug and have them define CMAKE_BULD_TYPE=RELWITHDEBINFO. Otherwise, in order to turn on some runtime checks, we force users to create much larger binaries with release-debug.

We can't support all of the possible tweaks to a Trilinos configuration in just a few build-name keywords and users can always override any cache vars they want (like you did by passing in -DCMAKE_BUILD_TYPE=RELWITHDEBINFO). But the options we chose should be "Least surprise" to the largest number of users.

I think we may need to poll a few people and see what they think about this.

@bartlettroscoe bartlettroscoe changed the title ATDM: Make 'release-debug' keyword set CMAKE_BUILD_TYPE=RELWITHDEBINFO instead of RELEASE ATDM: Add a release-debug build that adds debug symbols Oct 25, 2019
@bartlettroscoe
Copy link
Member Author

Actually, I think I might just do this by adding a new build-name keyword dbginfo that if included in the buildname will set the CMake cache var Trilinos_ENABLE_DEBUG_SYMBOLS=ON.

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Sep 26, 2021
@github-actions
Copy link

github-actions bot commented Nov 6, 2021

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Nov 6, 2021
@github-actions github-actions bot closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATDM Config Issues that are specific to the ATDM configuration settings ATDM DevOps Issues that will be worked by the Coordinated ATDM DevOps teams client: ATDM Any issue primarily impacting the ATDM project CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

1 participant