Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muelu: build error on OSX [xsdk/spack] #5630

Closed
balay opened this issue Aug 1, 2019 · 12 comments
Closed

muelu: build error on OSX [xsdk/spack] #5630

balay opened this issue Aug 1, 2019 · 12 comments
Labels
impacting: configure or build The issue is primarily related to configuring or building pkg: MueLu system: osx type: bug The primary issue is a bug in Trilinos code or tests

Comments

@balay
Copy link
Contributor

balay commented Aug 1, 2019

trilinos@develop build fails on OSX [with xcode clang+gfortran] build.

Attaching the build log

cc: @jwillenbring @keitat
spack-build-out.txt

@balay balay added the type: bug The primary issue is a bug in Trilinos code or tests label Aug 1, 2019
@mhoemmen
Copy link
Contributor

mhoemmen commented Aug 1, 2019

@trilinos/muelu @trilinos/xpetra I had also reported this here, but that issue got conflated with another issue that got fixed. The original Clang build issue remains.

@mhoemmen mhoemmen added impacting: configure or build The issue is primarily related to configuring or building pkg: MueLu system: osx labels Aug 1, 2019
@jwillenbring
Copy link
Member

@trilinos/muelu Any thoughts on this issue? We are trying to resolve this for the ECP xSDK release.

@keitat
Copy link
Contributor

keitat commented Aug 15, 2019

We are planning to release xSDK-0.5.0 on 9/12. This bug needs to be fixed for the release.

@jhux2
Copy link
Member

jhux2 commented Aug 16, 2019

@keitat and I talked about this. I’ve got some high priority items to take care of, then I’ll fix this. I believe the fix should be fairly straightforward.

Sent with GitHawk

@jhux2
Copy link
Member

jhux2 commented Aug 16, 2019

Btw, @balay reported this in an earlier issue that I believe is still open.

Sent with GitHawk

@balay
Copy link
Contributor Author

balay commented Oct 2, 2019

A reminder: this issue still comes up on osx build of trilinos@develop

@jhux2
Copy link
Member

jhux2 commented Oct 2, 2019

@balay Thank you for the reminder. @keitat had told me that the xsdk release was delayed -- is there a new date?

@balay
Copy link
Contributor Author

balay commented Oct 2, 2019

xsdk release is at the end of oct.

However, each individual packages were to provide a release (or equivalent) by end of sept [as some of the individual packages had this deadline for their ECP quarterly report].

So xsdk release was extended to end of oct [requeted this extension from ECP] - this way we can do testing with stable packages - [and have some time to deal with any issues that might come up]

@jwillenbring
Copy link
Member

jwillenbring commented Oct 10, 2019

@jhu2 Due to the timing of the xSDK release, I went ahead and created a trilinos-release-12-18-branch for testing to occur on. If you have not implemented this fix yet, please do so on that branch and then apply the fix also to develop.

(An earlier version of this comment previously incorrectly listed 12-14-branch)

trilinos-autotester added a commit that referenced this issue Oct 16, 2019
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: MueLu: fix issue #5630
PR Author: jhux2
@jhux2
Copy link
Member

jhux2 commented Oct 16, 2019

Due to the timing of the xSDK release, I went ahead and created a trilinos-release-12-18-branch for testing to occur on. If you have not implemented this fix yet, please do so on that branch and then apply the fix also to develop.

@jwillenbring @balay The fix was merged to Trilinos develop yesterday. I just cherry-picked over to trilinos-release-12-18-branch. Please let me know if this fixes the problem.

@balay
Copy link
Contributor Author

balay commented Oct 16, 2019

@jhux2 Thanks! I'm now able to build trilinos on OSX via spack/xsdk [with both xcode/clang and brew/gcc]

@jhux2
Copy link
Member

jhux2 commented Oct 16, 2019

Closing as fixed.

@jhux2 jhux2 closed this as completed Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impacting: configure or build The issue is primarily related to configuring or building pkg: MueLu system: osx type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

5 participants