Tpetra: compile error in FECrsMatrix unit-test

[alanw0]

Bug Report

@trilinos/<PackageName>

Description

What went wrong? What should have happened? Do you have an idea what might
fix things? How has this bug affected you? What are you trying to accomplish?
What specifically must we demonstrate to call this work complete?

Steps to Reproduce

1. SHA1: b3a8dc8 (develop branch)

/path/Trilinos/packages/tpetra/core/test/FECrsMatrix/FECrsMatrix_UnitTests.cpp:369:3: required from here
/path/Trilinos/packages/tpetra/core/test/FECrsMatrix/FECrsMatrix_UnitTests.cpp:119:71: error: 'eps' is not a member of 'Teuchos::ScalarTraits'
const Mag tol = errorTolSlack * Teuchos::ScalarTraits::eps();
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

[mhoemmen]

@alanw0 Best practice is to surround error messages in triple back quotes, so that GitHub does not reformat the error message incorrectly. This is why I can't see the error message correctly. In particular, the Scalar type doesn't show, because it's in angle brackets, that GitHub tries to treat like an HTML tag. I will show it again below:

/path/Trilinos/packages/tpetra/core/test/FECrsMatrix/FECrsMatrix_UnitTests.cpp:369:3:   required from here
/path/Trilinos/packages/tpetra/core/test/FECrsMatrix/FECrsMatrix_UnitTests.cpp:119:71: error: 'eps' is not a member of 'Teuchos::ScalarTraits<long int>'
const Mag tol = errorTolSlack * Teuchos::ScalarTraits<Scalar>::eps();
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

The test is trying to build with Scalar=long.

[alanw0]

ok thanks Mark.

[mhoemmen]

@trilinos/tpetra The problem is that the test tries to instantiate the test for Scalar=GlobalOrdinal. This is because the test uses the TPETRA_INSTANTIATE_SLGN macro:

Trilinos/packages/tpetra/core/test/FECrsMatrix/FECrsMatrix_UnitTests.cpp

Line 369 in e4ab0c3

TPETRA_INSTANTIATE_SLGN( UNIT_TEST_GROUP )

The easy fix is to use TPETRA_INSTANTIATE_SLGN_NO_ORDINAL_SCALAR. I will submit a PR with this change.