Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrepid2 unit tests failing in new ATDM 'release-debug' builds on 'waterman' #3681

Closed
fryeguy52 opened this issue Oct 19, 2018 · 2 comments
Closed
Labels
client: ATDM Any issue primarily impacting the ATDM project PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Intrepid2 type: bug The primary issue is a bug in Trilinos code or tests

Comments

@fryeguy52
Copy link
Contributor

fryeguy52 commented Oct 19, 2018

CC: @trilinos/intrepid2 , @mperego (Trilinos Discretizations Product Lead), @bartlettroscoe

Next Action Status

PR #3688 merged on 10/21/2018 resulted in all these Intrepid2 tests newly passing on 10/22/2018.

Description

As shown in this query the tests:

  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Serial_Test_01_SLFadDouble_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Serial_Test_01_SLFadDFad_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Serial_Test_01_SFadSFad_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Serial_Test_01_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Cuda_Test_01_SFadSFad_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Cuda_Test_01_MPI_1
  • Intrepid2_unit-test_Discretization_Basis_HDIV_TET_In_FEM_Cuda_Test_01_DFadDFad_MPI_1

are failing in the builds:

  • Trilinos-atdm-waterman-cuda-9.2-release-debug
  • Trilinos-atdm-waterman-gnu-release-debug-openmp

Steps to Reproduce

One should be able to reproduce this failure on waterman as described in:

$ cd <some_build_dir>/

$ source $TRILINOS_DIR/cmake/std/atdm/load-env.sh cuda-9.2-release-debug

$ cmake \
  -GNinja \
  -DTrilinos_CONFIGURE_OPTIONS_FILE:STRING=cmake/std/atdm/ATDMDevEnv.cmake \
  -DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_Intrepid2=ON \
  $TRILINOS_DIR

$ make NP=20

$ bsub -x -Is -n 20 ctest -j20
@fryeguy52 fryeguy52 added type: bug The primary issue is a bug in Trilinos code or tests pkg: Intrepid2 client: ATDM Any issue primarily impacting the ATDM project labels Oct 19, 2018
@mperego
Copy link
Contributor

mperego commented Oct 19, 2018

@fryeguy52 thanks. I'll try to fix them soon. I think it is just a matter of tolerances being too tight.

@bartlettroscoe bartlettroscoe changed the title Intrepid2 unit tests failing on ATDM waterman builds Intrepid2 unit tests failing in new ATDM 'release-debug' builds on waterman builds Oct 20, 2018
@bartlettroscoe bartlettroscoe changed the title Intrepid2 unit tests failing in new ATDM 'release-debug' builds on waterman builds Intrepid2 unit tests failing in new ATDM 'release-debug' builds on 'waterman' Oct 20, 2018
mperego added a commit to mperego/Trilinos that referenced this issue Oct 21, 2018
mperego added a commit to mperego/Trilinos that referenced this issue Oct 21, 2018
@bartlettroscoe
Copy link
Member

After the merge of PR #3688 yesterday, we are seeing these Intrepid2 tests newly passing in these builds today.

As shown here , the 7 failing Intrepid2 tests for the build Trilinos-atdm-waterman-cuda-9.2-release-debug described in this Issue have bee fixed as of today (see the -7 subscript and +7 superscript for the number of failing and passing tests for Intrepid, respectfully). And you can see the newly passing Intrepid2 tests for this build here.

And we see 5 Intrepid2 tests newly passing today for the build Trilinos-atdm-waterman-gnu-release-debug-openmp here and here.

Closing as complete.

@bartlettroscoe bartlettroscoe added the PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area label Nov 30, 2018
tjfulle pushed a commit to tjfulle/Trilinos that referenced this issue Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client: ATDM Any issue primarily impacting the ATDM project PA: Discretizations Issues that fall under the Trilinos Discretizations Product Area pkg: Intrepid2 type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

3 participants