Tpetra: Purge deprecated Kokkos functions ptr_on_device and dimension_N #2705
Assignees
Labels
Comments
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/tpetra Kokkos::View methods ptr_on_device() and dimension_N() (replace N with 0, 1, 2, ...) have been deprecated for a long time. Kokkos has replaced them with data() resp. extent(N). This commit replaces all uses of the deprecated methods in Tpetra, with their nondeprecated replacements. This fixes #2705.
|
PR #2707 has a fix for this issue. |
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/tpetra Kokkos::View methods ptr_on_device() and dimension_N() (replace N with 0, 1, 2, ...) have been deprecated for a long time. Kokkos has replaced them with data() resp. extent(N). This commit replaces all uses of the deprecated methods in Tpetra, with their nondeprecated replacements. This fixes #2705.
|
I just merged PR #2707 into develop, that fixes this issue. Thanks all! |
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/ifpack2 See #2705 for context.
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/xpetra @trilinos/muelu See #2705 for context.
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/trilinoscouplings See #2705 for context.
mhoemmen
pushed a commit
that referenced
this issue
May 9, 2018
@trilinos/teuchos See #2705 for context.
mhoemmen
pushed a commit
that referenced
this issue
May 10, 2018
mhoemmen
pushed a commit
that referenced
this issue
May 10, 2018
mhoemmen
pushed a commit
that referenced
this issue
May 10, 2018
mhoemmen
pushed a commit
that referenced
this issue
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kokkos has already deprecated and will soon remove
Kokkos::Viewmethodsptr_on_deviceanddimension_N(replace N with 0, 1, 2, etc.). Sierra (@rrdrake , @prwolfe ) is already seeing build errors, since they don't enable the macro that enables deprecated code. I will fix this in Tpetra. Replaceptr_on_devicewithdataanddimension_Nwithextent(N).@trilinos/tpetra
The text was updated successfully, but these errors were encountered: