Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSQR requires Kokkos::Serial enabled #2668

Closed
etphipp opened this issue May 2, 2018 · 3 comments
Closed

TSQR requires Kokkos::Serial enabled #2668

etphipp opened this issue May 2, 2018 · 3 comments

Comments

@etphipp
Copy link
Contributor

etphipp commented May 2, 2018

[ 73%] [ 73%] Building CXX object packages/tpetra/tsqr/src/CMakeFiles/kokkostsqr.dir/Tsqr_SeqTest.cpp.o
Building CXX object packages/tpetra/tsqr/src/CMakeFiles/kokkostsqr.dir/Tsqr_CombineTest.cpp.o
In file included from /home/etphipp/project/atdm/sparc/Trilinos/Trilinos/packages/tpetra/tsqr/src/Tsqr_Combine.hpp:50:0,
                 from /home/etphipp/project/atdm/sparc/Trilinos/Trilinos/packages/tpetra/tsqr/src/Tsqr_CombineTest.cpp:48:
/home/etphipp/project/atdm/sparc/Trilinos/Trilinos/packages/tpetra/tsqr/src/Tsqr_CombineNative.hpp:196:69: error: ‘Serial’ is not a member of ‘Kokkos’
          const Kokkos::View<const scalar_type*, Kokkos::LayoutLeft, Kokkos::Serial>& x,

Is this intended?

@trilinos/tpetra

@mhoemmen
Copy link
Contributor

mhoemmen commented May 2, 2018

@etphipp Argh OK I'll fix this, sorry! PR testers don't have a Serial disabled option.

@mhoemmen mhoemmen self-assigned this May 2, 2018
mhoemmen pushed a commit that referenced this issue May 2, 2018
@mhoemmen
Copy link
Contributor

mhoemmen commented May 2, 2018

@etphipp PR #2668 fixes this; please review and approve if OK. Thanks!

mhoemmen pushed a commit that referenced this issue May 3, 2018
@mhoemmen
Copy link
Contributor

mhoemmen commented May 3, 2018

Fixed in develop via PR #2668; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants