Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MueLu: delete ShiftedLaplacian interface? #2608

Closed
jhux2 opened this issue Apr 20, 2018 · 4 comments
Closed

MueLu: delete ShiftedLaplacian interface? #2608

jhux2 opened this issue Apr 20, 2018 · 4 comments
Assignees
Labels
MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: MueLu

Comments

@jhux2
Copy link
Member

jhux2 commented Apr 20, 2018

Would anyone object if I delete the ShiftedLaplacian interface? I know of no current users. The interface isn't maintained, and takes well over 5 minutes to compile.

@trilinos/muelu

@jhux2 jhux2 self-assigned this Apr 20, 2018
@cgcgcg
Copy link
Contributor

cgcgcg commented Apr 23, 2018

Instead of outright deleting it, maybe just don't compile it by default? Or is it actually broken?

@jhux2
Copy link
Member Author

jhux2 commented Apr 24, 2018

Instead of outright deleting it, maybe just don't compile it by default? Or is it actually broken?

It's not broken, as the Helmholtz tests exercise the interface, but it's badly in need of a redesign. One option would be to guard it with an experimental flag.

cgcgcg added a commit to cgcgcg/Trilinos that referenced this issue Jul 2, 2018
cgcgcg added a commit to cgcgcg/Trilinos that referenced this issue Jul 3, 2018
cgcgcg added a commit to cgcgcg/Trilinos that referenced this issue Jul 18, 2018
cgcgcg added a commit to cgcgcg/Trilinos that referenced this issue Jul 19, 2018
@github-actions
Copy link

github-actions bot commented Jun 5, 2021

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 5, 2021
@jhux2
Copy link
Member Author

jhux2 commented Jun 7, 2021

closing as fixed by PR #3047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: MueLu
Projects
Status: Done
Development

No branches or pull requests

2 participants