Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teuchos: undefined functions #10892

Closed
kliegeois opened this issue Aug 17, 2022 · 3 comments
Closed

Teuchos: undefined functions #10892

kliegeois opened this issue Aug 17, 2022 · 3 comments
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests

Comments

@kliegeois
Copy link
Contributor

Bug Report

@trilinos/teuchos
@bartlettroscoe @cgcgcg

Description

It seems that there are 2 functions which are declared but are not defined in Teuchos:

It looks like both of them could be remove.

This has been noticed when trying to import a shared library built using pybind11 of Teuchos from python.
It is strange that these undefined symbols have never been an issue up to today.
@kliegeois kliegeois added type: bug The primary issue is a bug in Trilinos code or tests pkg: Teuchos Issues primarily dealing with the Teuchos Package labels Aug 17, 2022
@bartlettroscoe
Copy link
Member

make_char_nfa is declared here packages/teuchos/parser/src/Teuchos_FiniteAutomaton.hpp and then defined here packages/teuchos/parser/src/Teuchos_FiniteAutomaton.cpp with a different signature.

CC: @ibaned

aboutBuild is declared here packages/teuchos/core/src/Teuchos_Utils.hpp and is not defined.

This was code initially written by Kevin Long 20+ years ago which was just copied into that file.

Note that Trilinos really needs to be cleaned up and have all of the PR builds put on -Wl,--no-undefined for the creation of all libs. That would ensure this never happens again.

@kliegeois, would you be willing to put in a PR to remove the undefined functions?

@kliegeois
Copy link
Contributor Author

@bartlettroscoe sure, I am on it! Thanks!

kliegeois added a commit to kliegeois/Trilinos that referenced this issue Aug 17, 2022
@kliegeois
Fix trilinos#10892
f7f75fd
@kliegeois kliegeois mentioned this issue Aug 17, 2022
Merged
trilinos-autotester added a commit that referenced this issue Aug 18, 2022
@trilinos-autotester
Merge Pull Request #10894 from kliegeois/Trilinos/fix_undefined_teuch…
b1a864d 
…os_functions

Automatically Merged using Trilinos Pull Request AutoTester
PR Title: Fix #10892
PR Author: kliegeois
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Aug 19, 2022
Merge 'trilinos/Trilinos:develop' (b1a864d) into 'tcad-charon/Trilino…
76a327a 
…s:develop' (d1bea2b).

* trilinos-develop:
  Fix trilinos#10892
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Aug 19, 2022
Merge 'trilinos/Trilinos:develop' (b1a864d) into 'tcad-charon/Trilino…
8906842 
…s:develop' (d1bea2b).

* trilinos-develop:
  Fix trilinos#10892
@cgcgcg
Copy link
Contributor

cgcgcg commented Aug 19, 2022

Fixed by #10894

@cgcgcg cgcgcg closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bartlettroscoe @cgcgcg @kliegeois