Skip to content

Commit

Permalink
Fix per suggestion on PR review
Browse files Browse the repository at this point in the history
Also add release notes to RELEASE_NOTES file. Revert original commit
since I committed all the whitespace changes in RELEASE_NOTES file by
mistake.
  • Loading branch information
srbdev committed Sep 13, 2023
1 parent 5a91a88 commit 5cdb42c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ INSTALL_BUILD_STATS_SCRIPTS()
# Install TriBITS so that other projects can use it
include(SetupTribitsInstall)

# See https://tribitspub.github.io/TriBITS/users_guide/index.html#project-name-must-find-all-tpl-libs
SET(Trilinos_MUST_FIND_ALL_TPL_LIBS_DEFAULT TRUE)

IF(${PROJECT_NAME}_ENABLE_YouCompleteMe)
INCLUDE(CodeCompletion)
ENDIF()
Expand Down
17 changes: 17 additions & 0 deletions RELEASE_NOTES
Original file line number Diff line number Diff line change
@@ -1,4 +1,21 @@

###############################################################################
# #
# Trilinos Release 15.0 Release Notes #
# #
###############################################################################

CMake

- Change the default for `Trilinos_MUST_FIND_ALL_TPL_LIBS` from `OFF` to
`ON`, by setting `Trilinos_MUST_FIND_ALL_TPL_LIBS_DEFAULT` to `ON`. It was
turned off by default because it breaks backward compatibility but it also
causes problems for new users and new configurations.

Users that do not want this new behavior can set
`-D Trilinos_MUST_FIND_ALL_TPL_LIBS=OFF`, which is backward compatible.


###############################################################################
# #
# Trilinos Release 14.2 Release Notes #
Expand Down

0 comments on commit 5cdb42c

Please sign in to comment.