Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: slice loop replace #688

Merged
merged 2 commits into from
Dec 2, 2023
Merged

chore: slice loop replace #688

merged 2 commits into from
Dec 2, 2023

Conversation

testwill
Copy link
Contributor

No description provided.

@testwill
chore: slice loop replace
279b3f9 
Signed-off-by: guoguangwu <[email protected]>
@jnichols-git
Copy link
Member

@testwill Chore PRs are welcome, and this is a good subject for one, but this isn't the only instance of this loop pattern. While we're here and looking at it, could you please also fix this pattern where it occurs elsewhere?

@jranson jranson requested a review from jnichols-git December 2, 2023 23:06
@jranson jranson merged commit 009d9dd into trickstercache:main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jranson jranson jranson approved these changes

@jnichols-git jnichols-git jnichols-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testwill @jnichols-git @jranson