Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing backends.paths #674

Closed
wants to merge 1 commit into from
Closed

fix parsing backends.paths #674

wants to merge 1 commit into from

Conversation

paragor
Copy link
Contributor

@paragor paragor commented May 25, 2023

fix parsing backends.paths

@paragor
fix config paths set
5cbfb5d 
Signed-off-by: novikov <[email protected]>
@paragor paragor force-pushed the fix-config-paths branch from 2a10f85 to 5cbfb5d Compare May 25, 2023 06:35
@jnichols-git jnichols-git added the duplicate This issue or pull request already exists label May 25, 2023
@jnichols-git
Copy link
Member

This is resolved in #672. Additionally, please make sure to copy over the elements of slices/maps, and not by reference; this can cause some undesired behavior when modifying either copy. Marking as duplicate for now--will leave open for a moment in case you have other thoughts on the issue.

@jranson
Copy link
Member

jranson commented Dec 2, 2023

@paragor Egor thanks for the contributions. We took #672 for this fix, which clones the path configs, just in case taking the existing references could cause unforseen issues.

@jranson jranson closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paragor @jnichols-git @jranson