remove gorilla/mux (deprecated)

[jranson]

This patch duplicates gorilla/mux, which is archived / no longer supported, into a new router package; and implements a Router interface atop the original gorilla *Router struct (now lowercase r *router)

fixes #628

Signed-off-by: James Ranson [email protected]

[coveralls]

Pull Request Test Coverage Report for Build 3982313854

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 26 of 78 (33.33%) changed or added relevant lines in 8 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-4.6%) to 89.316%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/proxy/handlers/purge.go	0	1	0.0%
pkg/router/middleware.go	0	3	0.0%
pkg/router/regexp.go	0	6	0.0%
pkg/router/route.go	0	13	0.0%
pkg/router/router.go	0	29	0.0%

Totals
Change from base Build 3982074317:	-4.6%
Covered Lines:	16068
Relevant Lines:	17990

---

💛 - Coveralls

[tamalsaha]

It feels weird to see pointer to an interface. Is this necessary?

[jranson]

hi @tamalsaha - not sure i understand here. While Router is an interface, Route is actually a struct. Just FYI, we'll be switching to https://github.com/julienschmidt/httprouter before we cut the next beta release, since it is much more performant than gorilla/mux.

[tamalsaha]

While Router is an interface, Route is actually a struct.

Ah! Sorry, I missed that Router and Route thing. I understand now.

Just FYI, we'll be switching to julienschmidt/httprouter

Wow! It must be a major rework of the project.