Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set int upper bound #624

Merged
merged 1 commit into from
Dec 15, 2022
Merged

set int upper bound #624

merged 1 commit into from
Dec 15, 2022

Conversation

jranson
Copy link
Member

@jranson jranson commented Dec 15, 2022

this patch addresses incorrect conversion between integer types when loading port configs

@jranson jranson requested a review from jnichols-git December 15, 2022 20:18
@jranson
set int upper bound
c653c9d 
Signed-off-by: James Ranson <[email protected]>
@coveralls
Copy link

coveralls commented Dec 15, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3707633443

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 94.337%
Files with Coverage Reduction New Missed Lines %
pkg/proxy/engines/deltaproxycache.go 2 84.5%
pkg/cache/bbolt/bbolt.go 4 88.55%
Totals Coverage Status
Change from base Build 3615932492: -0.04%
Covered Lines: 16025
Relevant Lines: 16987
💛 - Coveralls

@jranson jranson merged commit 2eeb4ba into trickstercache:main Dec 15, 2022
@jranson jranson deleted the int-conversion-fix branch December 15, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LimitlessEarth LimitlessEarth LimitlessEarth approved these changes

@jnichols-git jnichols-git Awaiting requested review from jnichols-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jranson @coveralls @LimitlessEarth