V1.1.0 beta2 #421
Merged
V1.1.0 beta2 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 5, 2020 20:13
added 10 commits
May 9, 2020 10:02
| // TODO: This looks suspicious | ||
| rsc.OriginConfig.DearticulateUpstreamRanges = true | ||
| // // TODO: This looks suspicious | ||
| // rsc.OriginConfig.DearticulateUpstreamRanges = true |
There was a problem hiding this comment.
I believe this was put in for debugging purposes and forgotten about; so it is commented for Beta2 and will be scrubbed completely in the next release
Comment on lines
+156
to
+162
| // span := trace.SpanFromContext(pr.upstreamRequest.Context()) | ||
| // _, span := tspan.NewChildSpan(pr.Context(), rsc.Tracer, "Fetch") | ||
| // if span != nil { | ||
| // pr.upstreamRequest = pr.upstreamRequest.WithContext(trace.ContextWithSpan(pr.upstreamRequest.Context(), span)) | ||
| // defer span.End() | ||
| // } | ||
|
|
There was a problem hiding this comment.
this should be unneeded so as to minimize the span count, but I kept in comments in case it needs to come back, will be scrubbed in next release.
LimitlessEarth
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.