Fix parameter conversion errors and simplify request time parsing #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values in the test fixtures are taken the examples in the Prometheus documentation: https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries ...and from empirical testing using Prometheus version 2.2.0-rc.1.
Simplify the request time parsing to only accept values documented in the Prometheus HTTP API docs: https://prometheus.io/docs/prometheus/latest/querying/api/ ...which also means removing the ability to pass relative times. Do this to simplify the implementation and align the API more closely to the values accepted by Prometheus' HTTP API. Also fixes this error, which I found was occuring whenever a float value was passed to the API: time=2018-04-07T11:08:39.715529214Z app=trickster caller=trickster/handlers.go:385 level=error event="request parameter parser error" paramName=start paramValue=1523097519.71 detail="strconv.ParseInt: parsing \"1523097519.71000\": invalid syntax"
jranson
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
lgtm RIP, relative time converter! @mattbostock thank you for contributing and holding us to good standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the request time parsing to only accept values documented in
the Prometheus HTTP API docs:
https://prometheus.io/docs/prometheus/latest/querying/api/
...which also means removing the ability to pass relative times.
Do this to simplify the implementation and align the API more closely to
the values accepted by Prometheus' HTTP API.
Also fixes this error, which I found was occuring whenever a float value
was passed to the API: