[SYCL][XRT][Vitis] Fix some failing tests + improve device detection of xrt_pi #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryell
changed the title
keryell
requested changes
May 27, 2022
sycl/plugins/xrt/pi_xrt.cpp
Outdated
| @@ -339,7 +339,9 @@ struct _pi_device | |||
|
|
|||
| private: | |||
| native_type xrtDevice_; | |||
| ref_counted_ref<_pi_platform> platform_; | |||
| /// _pi_platform hold a counting reference onto all its _pi_device so we do | |||
There was a problem hiding this comment.
Suggested change
| /// _pi_platform hold a counting reference onto all its _pi_device so we do | |
| /// _pi_platform holds a counting reference onto all its _pi_device so we do |
sycl/plugins/xrt/pi_xrt.cpp
Outdated
| /// _pi_device hold a counting reference onto _pi_platform so we do not keep | ||
| /// counting reference on devices to prevent circular dependency. | ||
| std::vector<_pi_device*> devices_; | ||
| std::vector<ref_counted_ref<_pi_device>> devices_; |
There was a problem hiding this comment.
I guess you need to update the comment accordingly.
|
do not merge yet I started merging from upstream and this will be rebased on the merge |
keryell
requested changes
Jun 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.