e2e tests: a small step towards arm and docs tweaks #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make newlines after heading consistent.
- Make navigation notation consistent.
- Use simpler code formatting, keep double backticks only where needed.
- Explain M1 Mac situation and link to corresponding issue.
- Reword a sentence to follow natural time sequence.
- Remove dot prefix from relative paths
Paths with the dot appear as relative to the current file (e2e-web.md)
but that's wrong. Remove the dot from relative paths forcing the reader
to figure out what the path is relative to. Also note it at top of the
manual.
1.4 release doesn't provide builds for arm64. Bump to the latest version (1.12) which does.
|
The failing job doesn't seem to be related to changes in this PR. Might that be a temporary error fixable by a mere retry? |
|
I've restarted and it seems to me that. |
tsusanka
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few last days I spent trying to run e2e tests on my M1 Mac. This PR brings 1) a small patch that brings us closer to that 2) Some minor docs tweaks.
This alone isn't enough to make the e2e tests run on arm machines, that will need far more work. I decided to not spend time on that now, deffered the effort to this issue and pushed what I got so far with this PR.
RBC (review by commits) & DNS (do not squash) please .)