This repository was archived by the owner on Apr 16, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work-in-progress PR together with trezor/trezor-crypto#144 adds support for Groestlcoin (GRS). However ATM it breaks support for other coins. I'm opening this PR to ask how it is better to integrate GRS specific changes.
GRS uses signle SHA256 instead of double SHA256 for transaction and message signing. How it is better to check whether we should use double or signle SHA256? Should I add new field
"double_sha256_signing"
tocoins.json
. Or just check coin name withstrcmp
? Or any other way?