Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xmr): add missing view_tags to hf15 #2345

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

ph4r05
Copy link
Contributor

@ph4r05 ph4r05 commented Jun 20, 2022

Adds support for view-tags monero-project/monero#8061, new HF15 feature that was missing in the recent PRs. @selsta pinged me with this missing feature monero-project/monero#8299 (comment)

As wallet is using view_key to derive view tags, tx receiving code on the wallet side does not require changes.

PR is related to the:

@ph4r05 ph4r05 requested review from matejcik and onvej-sl as code owners June 20, 2022 17:49
@ph4r05 ph4r05 marked this pull request as draft June 20, 2022 17:49
@ph4r05 ph4r05 force-pushed the pr/xmr-view-tags branch from 6678255 to 1fcd900 Compare June 21, 2022 09:10
@ph4r05 ph4r05 marked this pull request as ready for review June 21, 2022 09:10
@ph4r05
Copy link
Contributor Author

ph4r05 commented Jun 21, 2022

@matejcik PR is ready for review, testing binary was released https://github.com/ph4r05/monero/releases/tag/v0.17.3.2-dev-tests-u18.04-03 shasum256 3280aeef795baf2fc46687c07ac4131e5a18767ecdd3af83cf17823ebb2d1007

I've modified CI nix file to use a new binary.

HF15 will be activated on 16th July 2022 according to the https://www.getmonero.org/2022/04/20/network-upgrade-july-2022.html

@ph4r05 ph4r05 force-pushed the pr/xmr-view-tags branch 4 times, most recently from 5bf88b0 to 988f462 Compare June 22, 2022 16:30
@matejcik
Copy link
Contributor

matejcik commented Jun 27, 2022

our release will be August 17th at the soonest.

will Trezor continue to work after HF15 or will it just be broken?

@ph4r05
Copy link
Contributor Author

ph4r05 commented Jun 27, 2022

@matejcik After HF15 is activated, the last public trezor firmware wont be able to sign transactions, so the integration is broken until new firmware release is out. (Assuming HF15 changes are enforced after the fork, I asked selsta about it in the monero PR).

The only way for users being able to sign their transactions is to build their custom firmware or install unverified builds :/

@matejcik matejcik force-pushed the pr/xmr-view-tags branch 2 times, most recently from 07f0a9c to fc18a31 Compare June 28, 2022 11:04
@matejcik
Copy link
Contributor

CI is horribly broken but that will hopefully go away with the merge

@matejcik matejcik merged commit 62ab48d into trezor:master Jun 28, 2022
@prusnak
Copy link
Member

prusnak commented Jul 1, 2022

HF15 postponed to 13th August: https://www.getmonero.org/2022/04/20/network-upgrade-july-2022.html - so we don't have to push the FW update in July

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants