-
-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xmr): add missing view_tags to hf15 #2345
Conversation
@matejcik PR is ready for review, testing binary was released https://github.com/ph4r05/monero/releases/tag/v0.17.3.2-dev-tests-u18.04-03 shasum256 I've modified CI nix file to use a new binary. HF15 will be activated on 16th July 2022 according to the https://www.getmonero.org/2022/04/20/network-upgrade-july-2022.html |
5bf88b0
to
988f462
Compare
our release will be August 17th at the soonest. will Trezor continue to work after HF15 or will it just be broken? |
@matejcik After HF15 is activated, the last public trezor firmware wont be able to sign transactions, so the integration is broken until new firmware release is out. (Assuming HF15 changes are enforced after the fork, I asked selsta about it in the monero PR). The only way for users being able to sign their transactions is to build their custom firmware or install unverified builds :/ |
07f0a9c
to
fc18a31
Compare
fc18a31
to
61c3071
Compare
CI is horribly broken but that will hopefully go away with the merge |
HF15 postponed to 13th August: https://www.getmonero.org/2022/04/20/network-upgrade-july-2022.html - so we don't have to push the FW update in July |
Adds support for view-tags monero-project/monero#8061, new HF15 feature that was missing in the recent PRs. @selsta pinged me with this missing feature monero-project/monero#8299 (comment)
As wallet is using view_key to derive view tags, tx receiving code on the wallet side does not require changes.
PR is related to the: