Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose string fragments in template string types #274

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

guillaumebrunerie
Copy link
Contributor

This pull request exposes _template_chars as string_fragment in template string types. The same change was made for regular template strings in Javascript recently, which made it much easier to do syntax highlighting for them, so it makes sense to do it for template string types too.

Checklist

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@amaanq
Copy link
Member

amaanq commented Feb 10, 2024

oops, this slipped past me, thank you

@amaanq
Copy link
Member

amaanq commented Feb 14, 2024

forgot to merge, thanks again!

@amaanq amaanq merged commit 198e2ea into tree-sitter:master Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants