Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C bindings #199

Merged
merged 3 commits into from
Mar 28, 2022
Merged

C bindings #199

merged 3 commits into from
Mar 28, 2022

Conversation

mattmassicotte
Copy link
Contributor

This PR adds a Makefile that can build and install static/dynamic libraries and headers suitable for C-compatible language clients. This is just automation that makes the parser easier to use. It does not affect the parser functionality in any way.

All the components are standardized and parser-agnostic aside from the name, version, and some informational comments in the .pc file.

The backstory: tree-sitter/tree-sitter#1488
The first implementation: tree-sitter/tree-sitter-go#56

@mattmassicotte
Copy link
Contributor Author

Hello! Just wondering if there is anything I can help out with here. Would be happy to!

@aryx
Copy link
Contributor

aryx commented Mar 25, 2022

hmm the windows CI are failing. I think it's similar to tree-sitter/tree-sitter-java#106
where we need to switch to nodejs 16.

@mattmassicotte
Copy link
Contributor Author

Ok great! I've made #206

@mattmassicotte
Copy link
Contributor Author

However, I would like to update the content here slightly, so please hold off for a just moment while I do that.

@mattmassicotte
Copy link
Contributor Author

Updated Makefile and input files to be generic to the parser name, which makes it possible to just copy across parsers.

Also, this CI failure appears to be related to CI configuration (https://stackoverflow.com/questions/57541402/node-gyp-configure-got-gyp-err-find-vs), and wasn't affected by this change.

What do you think?

@aryx aryx merged commit 0b107de into tree-sitter:master Mar 28, 2022
@mattmassicotte
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants