-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3.12 removed distutils, add fallback to setuptools #161
Conversation
looks good, a bit annoying that Python removed distutils though.. |
Fix #162 (by keeping distutils for the moment) |
@GabDug should 3.12 be added to the build matrix in the CI pipeline? |
Updated Not sure if it's needed in |
Both workflows are running fine on my fork: |
e4bd27d
to
018e8da
Compare
@GabDug this fails with 3.12 which I just added - do we need to install dependencies somehow first? How would that be done Nvm, was just a lint thing |
3e8643a
to
6a568a8
Compare
6a568a8
to
70f3a3a
Compare
Thanks for the PR and your patience! |
Hello!
distutils
was removed in Python 3.12, burt is included in setuptools 48+.We might want to add setuptools to the requirements for Python, maybe as extra?
I'm open for discussion for better ways to add 3.12 support :)
Have a nice day!