Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 3.12 removed distutils, add fallback to setuptools #161

Merged
merged 4 commits into from
Nov 12, 2023

Conversation

GabDug
Copy link
Contributor

@GabDug GabDug commented Oct 3, 2023

Hello!

distutils was removed in Python 3.12, burt is included in setuptools 48+.

We might want to add setuptools to the requirements for Python, maybe as extra?

I'm open for discussion for better ways to add 3.12 support :)

Have a nice day!

tree_sitter/__init__.py Outdated Show resolved Hide resolved
@amaanq
Copy link
Member

amaanq commented Oct 5, 2023

looks good, a bit annoying that Python removed distutils though..

@GabDug
Copy link
Contributor Author

GabDug commented Oct 9, 2023

Fix #162 (by keeping distutils for the moment)

@atapin
Copy link

atapin commented Nov 1, 2023

@GabDug should 3.12 be added to the build matrix in the CI pipeline?

@GabDug
Copy link
Contributor Author

GabDug commented Nov 1, 2023

Updated cibuildwheel to the latest version -- it adds wheels by default for CPython 3.12 and Pypy 3.10.

Not sure if it's needed in ci.yml: I see Pypy 3.9 and CPython 3.11 are not there, even though we build for these versions.

@GabDug
Copy link
Contributor Author

GabDug commented Nov 1, 2023

@amaanq amaanq force-pushed the fix/distutils-import branch from e4bd27d to 018e8da Compare November 12, 2023 05:26
@amaanq
Copy link
Member

amaanq commented Nov 12, 2023

@GabDug this fails with 3.12 which I just added - do we need to install dependencies somehow first? How would that be done

Nvm, was just a lint thing

@amaanq amaanq force-pushed the fix/distutils-import branch from 3e8643a to 6a568a8 Compare November 12, 2023 10:41
@amaanq amaanq force-pushed the fix/distutils-import branch from 6a568a8 to 70f3a3a Compare November 12, 2023 11:02
@amaanq
Copy link
Member

amaanq commented Nov 12, 2023

Thanks for the PR and your patience!

@amaanq amaanq merged commit 882ece6 into tree-sitter:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants