Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry at okhttp native Socket closed exception #364

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

miniway
Copy link
Member

@miniway miniway commented Dec 18, 2024

okhttp can raise java.net.SocketException("Socket closed") from okio

For this exception, it doesn't retry as it's thought as an unknown SocketException. Unfortunately there's no way to identify by an exception class but checking error message.

@miniway miniway requested a review from yuokada December 18, 2024 08:55
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miniway miniway merged commit 518bf44 into master Dec 18, 2024
7 checks passed
@miniway miniway deleted the retry_at_socket_closed branch December 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants