Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate CI failure with random sleep #347

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Mitigate CI failure with random sleep #347

merged 4 commits into from
Jul 11, 2024

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Jul 10, 2024

No description provided.

@yuokada yuokada requested a review from tiana528 July 10, 2024 05:18
@yuokada yuokada force-pushed the mitigate-ci-failure branch from b54276b to 87c006a Compare July 10, 2024 05:48
@yuokada yuokada force-pushed the mitigate-ci-failure branch from 87c006a to bdc71cf Compare July 11, 2024 01:34
@github-actions github-actions bot added the doc label Jul 11, 2024
Copy link
Contributor

@tiana528 tiana528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

name: Sleep to avoid resource name conflict
command: |
if [[ $CIRCLE_JOB != "build-jdk8" ]]; then
sleep $((RANDOM % 30))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using sleep $((15 + RANDOM % 15)) to always sleep 15~30 seconds?
BTW, what is the purpose of having both jdk8 and jdk17 build?
Just for checking whether the project is still jdk8 compatible? I feel we can drop the support of jdk8 considering it has been deprecated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I changed the sleep strategy.

In my understanding, JDK 8 is maintained by some vendors.
https://endoflife.date/eclipse-temurin / https://endoflife.date/redhat-build-of-openjdk

@yuokada yuokada merged commit 75366cd into master Jul 11, 2024
7 checks passed
@yuokada yuokada deleted the mitigate-ci-failure branch July 11, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants