Encourage try-with-resource #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuokada
approved these changes
Jan 31, 2023
| } | ||
| catch (Exception e) { | ||
| logger.error("Failed to delete query: {}", name, e); | ||
| try (TDClient client1 = client; |
There was a problem hiding this comment.
I'm not sure whether it's necessary to use try-with-resource statement in this case.
The resources are declared in another method. For that case, I assume that it's not necessary.
I think that the previous code is enough.
There was a problem hiding this comment.
I think try-with-resource is better since it ensures that server is closed even when client.deleteSavedQuery throws exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try-with-resource is highly encouraged since it ensure resource closing with simpler code