Add support for (upcoming) Oracle JDK 9 and refactor similar recipes to reduce duplications #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With these PPA packages, the Java Cryptography Extension (JCE) unlimited strength jurisdiction policy files are correctly installed for Oracle JDK versions 7 and 8. A similar package already exists for Oracle JDK 9, but effective ulimited strength policy files are not yet installed (this is probably normal during the Early Access phase).
Note: unlike oraclejk8, the oraclejkd7 setup cache files were not swept out so far.
I verified the git history of oraclejdk7 recipe, but could not find any state where such symbolic link was manually created. The former Michael's comments were orginally applied to the "non-architecture" directories, in comparison to openjdk installations which always contains the arch suffix. See also: - michaelklishin/jdk_switcher@db238c2 - michaelklishin/jdk_switcher@6988597 Note: I don't think it is necessary to manually create these links, since Travis environment are 64-bit only, but the jdk_switcher.sh can be kept unchanged for flexibility and consistency with the handling of other JDKs.
To be discussed, but I am not sure that it makes a lot of sense to cut this Chef "imperative procedure" into small methods, especially because we are here relying on a Ruby Module, not a Class.
This is a tiny (cosmetic) change, but I think that it makes things more readable (in source code, and also in chef run log output).
As these tools are no longer installed via a Gemfile, Developers and CI environments are more likely to run with different setup configurations. This could then help to figure out the cause of behavior gaps...
|
!!! 😻 !!! |
|
@meatballhat what about merging this now/soon, and you decide to ship (drawback: the |
|
@gildegoma I'm happy to merge soon (now?), exactly for the reasons you've mentioned! |
|
@meatballhat cool! Please do :) |
2 tasks
meatballhat
added a commit
that referenced
this pull request
Nov 23, 2015
Add support for (upcoming) Oracle JDK 9 and refactor similar recipes to reduce duplications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 9 should be "Feature Complete" in late 2015, and its "General Availability" is planned for September 2016. In the meantime, it is already possible to use Oracle JDK 9 "Early Access".
So far, I found only two limitations with the current versions of the Webupd8 PPA packages:
oracle-java9-unlimited-jce-policypackage exists and is already integrated)JAVA_HOME/jresubdirectory structure is not created yet)