Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy GitHub Pages symbolic links #989

Merged
merged 2 commits into from
May 30, 2019
Merged

Copy GitHub Pages symbolic links #989

merged 2 commits into from
May 30, 2019

Conversation

ashenm
Copy link
Contributor

@ashenm ashenm commented May 12, 2019

Instead ignoring symbolic links while deploying to GitHub Pages, the PR proposes to include symbolic links on deploy, which particularly benefit builds that bypasses Jekyll via .nojekyll.

@ashenm
Copy link
Contributor Author

ashenm commented May 12, 2019

#912

@BanzaiMan
Copy link
Contributor

Do you have a build that shows the problem and another that shows how this PR fixes it? Thanks.

@ashenm
Copy link
Contributor Author

ashenm commented May 30, 2019

The build log here as well as the following reproduce evince the exclusion of symbolic link 404.html concomitant of the current version of the rsync call.

ubuntu@64a9ce222102:~/workspace/S3Vault$ ls -Al dist/
total 360
lrwxrwxrwx 1 ubuntu ubuntu     10 May 30 06:17 404.html -> vault.html
-rw-r--r-- 1 ubuntu ubuntu  25783 May 30 06:17 amazon-cognito-auth.min.js
-rw-r--r-- 1 ubuntu ubuntu 321503 May 30 06:17 aws-sdk-2.384.0.min.js
-rw-r--r-- 1 ubuntu ubuntu      0 May 30 06:17 .nojekyll
-rw------- 1 ubuntu ubuntu    299 May 30 06:25 vault.css
-rw------- 1 ubuntu ubuntu   1604 May 30 06:25 vault.html
-rw------- 1 ubuntu ubuntu   7413 May 30 06:25 vault.min.js
ubuntu@64a9ce222102:~/workspace/S3Vault$ dpl --skip_cleanup=true --provider=pages --target-branch=assess-dpl --local-dir=dist --github-token="$GITHUB_TOKEN"
Installing deploy dependencies
Preparing deploy
Logged in as @ashenm (Ashen Gunaratne)
Deploying application
cd /tmp/d20190530-2093-1qmksbb/work
Initialized empty Git repository in /tmp/d20190530-2093-1qmksbb/work/.git/
Switched to a new branch 'assess-dpl'
cd -
cd /tmp/d20190530-2093-1qmksbb/work
skipping non-regular file "404.html"
commit 3663fff7a3663b2326684a8b49709ddd758e1241 (HEAD -> assess-dpl)
Author: Deployment Bot (from Travis CI) <[email protected]>
Date:   Thu May 30 06:44:29 2019 +0000

    Deploy  to github.com/.git:assess-dpl

 .nojekyll                  |  0
 amazon-cognito-auth.min.js | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 aws-sdk-2.384.0.min.js     |  9 +++++++++
 vault.css                  |  1 +
 vault.html                 |  1 +
 vault.min.js               | 14 ++++++++++++++
 6 files changed, 84 insertions(+)
Couldn't push the build to github.com/.git:assess-dpl

The alteration of rsync call to utilise the flag -l proposed by the PR yields the following facsimile which divulge the inclusion of symlink 404.html

ubuntu@64a9ce222102:~/workspace/S3Vault$ dpl --skip_cleanup=true --provider=pages --target-branch=assess-dpl --local-dir=dist --github-token="$GITHUB_TOKEN"
Installing deploy dependencies
Preparing deploy
Logged in as @ashenm (Ashen Gunaratne)
Deploying application
cd /tmp/d20190530-2131-1b1wsff/work
Initialized empty Git repository in /tmp/d20190530-2131-1b1wsff/work/.git/
Switched to a new branch 'assess-dpl'
cd -
cd /tmp/d20190530-2131-1b1wsff/work
commit f00e620a5039579b1ba60c1a4f006dad44884fa8 (HEAD -> assess-dpl)
Author: Deployment Bot (from Travis CI) <[email protected]>
Date:   Thu May 30 06:45:13 2019 +0000

    Deploy  to github.com/.git:assess-dpl

 .nojekyll                  |  0
 404.html                   |  1 +
 amazon-cognito-auth.min.js | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 aws-sdk-2.384.0.min.js     |  9 +++++++++
 vault.css                  |  1 +
 vault.html                 |  1 +
 vault.min.js               | 14 ++++++++++++++
 7 files changed, 85 insertions(+)
Couldn't push the build to github.com/.git:assess-dpl

@BanzaiMan BanzaiMan merged commit 40fae68 into travis-ci:master May 30, 2019
@ashenm ashenm deleted the patch-1 branch May 30, 2019 14:47
ashenm added a commit to ashenm/S3Vault that referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants