Skip to content

Commit

Permalink
fix(navigation): used valid markup for the nav list
Browse files Browse the repository at this point in the history
i would like this to be a `<nav/>` that contains a list, but since i'd need to do some more work to
have links that are wrapped in `<li>`s, this is better than a list that does not have `<li>`s as
children for now
  • Loading branch information
travi committed Jan 5, 2020
1 parent c6c6b97 commit 131a08a
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions src/molecules/navigation/presentational.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,16 @@ export function NavigationDrawer({open, onToggle, classes}) {
<IconButton onClick={onToggle}><ChevronLeft /></IconButton>
</div>
<Divider />
<nav>
<List>
<ListItem button component="a" href={travi.contact.website}>
<ListItemIcon><Home /></ListItemIcon>
<ListItemText primary="Home" />
</ListItem>
<ListItem button component="a" href="https://presentations.travi.org">
<ListItemIcon><Dvr /></ListItemIcon>
<ListItemText primary="Presentations" />
</ListItem>
</List>
</nav>
<List component="nav">
<ListItem button component="a" href={travi.contact.website}>
<ListItemIcon><Home /></ListItemIcon>
<ListItemText primary="Home" />
</ListItem>
<ListItem button component="a" href="https://presentations.travi.org">
<ListItemIcon><Dvr /></ListItemIcon>
<ListItemText primary="Presentations" />
</ListItem>
</List>
</Drawer>
);
}
Expand Down

0 comments on commit 131a08a

Please sign in to comment.