⚡️ Optimize ERC721 jumps #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to close this because I can't perform the check list, but it's here if you want it! |
|
haha ill be removing dapp support entirely soon |
|
lol its a bit upsetting this saves gas |
transmissions11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than putting
to.code.length == 0in aORconditional in the require, we can optimize by pulling this out of the require and wrapping the require inif (to.code.length != 0)Checklist
Ensure you completed all of the steps below before submitting your pull request:
dapp snapshot?npm run lint?forge test?dapp test?Pull requests with an incomplete checklist will be thrown out.
lol ok but I don't have Dapp setup on my computer