Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only _startIfAutoProceed if some files were actually added #2146

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Only _startIfAutoProceed if some files were actually added #2146

merged 1 commit into from
Mar 21, 2020

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Mar 20, 2020

Fixes #2126

With the new addFiles() method from #1949, autoProceed was run even if no files were actually added, because of errors/restrictions.

This PR fixes that — _startIfAutoProceed is only called if newFiles > 0.

@arturi arturi requested a review from goto-bus-stop March 20, 2020 20:21
@arturi arturi mentioned this pull request Mar 20, 2020
Closed
goto-bus-stop
goto-bus-stop approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arturi arturi merged commit f449783 into master Mar 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the addfiles-autoproceed-0 branch March 21, 2020 10:04
@arturi arturi mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uppy autoproceed along with maxFileSize restriction emits two error messages
2 participants
@arturi @goto-bus-stop