Introduce push configuration #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the `TXPushConfiguration` object that can hold the different configuration options available for the push translations functionality and adds any missing options: * Adds `overrideTags`, `overrideOccurrences`, `keepTranslations` and `dryRun` options. * Moves `purge` inside the `TXPushConfiguration`. * Ensures that the proper JSON keys are used when encoding the above options. * Adds documentation. * Replaces the `purge` argument of the `pushTranslations()` methods with the `TXPushConfiguration` object, ensuring that the default value holds the correct default values for each option. * Fixes small typo on README.
n1k0sv
previously approved these changes
Jul 7, 2023
* Bumps `TXNative.version` to 2.0.0. * Updates CHANGELOG with the changes implemented for 2.0.0.
n1k0sv
approved these changes
Jul 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
TXPushConfigurationobject that can hold the different configuration options available for the push translations functionality and adds any missing options:overrideTags,overrideOccurrences,keepTranslationsanddryRunoptions.purgeinside theTXPushConfiguration.purgeargument of thepushTranslations()methods with theTXPushConfigurationobject, ensuring that the default value holds the correct default values for each option.