Update CDSHandler logic to v2 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelabouras
force-pushed
the
stelios/feature/cds-v2
branch
from
88f5af4 to
405dd70
Compare
* Updates `CDSHandler` logic so that it can work with the version 2 of the CDS documentation. * Updates the response data structures that the new CDS version produces. * Updates the push logic with the new job oriented approach. * Updates unit test logic. * Adds unit tests for the new job oriented approach on push.
stelabouras
force-pushed
the
stelios/feature/cds-v2
branch
from
341e78c to
dd8e3cd
Compare
|
@nbasili Do you want me to make another commit in this PR that bumps the version to 1.0.0 or should I create a separate PR for that? |
|
Let's do this on the same PR and I re-approve for simplicity |
n1k0sv
previously approved these changes
Jul 28, 2021
stelabouras
force-pushed
the
stelios/feature/cds-v2
branch
from
f0830a9 to
62fe991
Compare
Refactors `pushTranslations()` method so that it also returns an array of possible errors that might get generated during the push logic. Exposes the `TXCDSError` enum so that consumers of the SDK can check if a returned error matches one of the errors on the enum.
* Bumps `TXNative.version` to 1.0.0 * Updates CHANGELOG with the changes implemented for v1.0.0
stelabouras
force-pushed
the
stelios/feature/cds-v2
branch
from
62fe991 to
1a6dec6
Compare
n1k0sv
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDSHandlerlogic so that it can work with the version 2of the CDS documentation.