Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the path argument to optional #1508

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Make the path argument to optional #1508

merged 5 commits into from
Feb 4, 2025

Conversation

YanVictorSN
Copy link
Contributor

Description:

  • Changed the Change path's type from String to Option in two places
  • Handle the case when path is None.

I also have to handle path in

pub fn auto_correct_revertible()

function.

Close #601

@smoelius

@YanVictorSN YanVictorSN requested a review from smoelius as a code owner February 4, 2025 15:34
@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smoelius
Copy link
Collaborator

smoelius commented Feb 4, 2025

Thanks, @YanVictorSN !

@smoelius smoelius added this pull request to the merge queue Feb 4, 2025
Merged via the queue into trailofbits:master with commit 60b17bf Feb 4, 2025
30 checks passed
@YanVictorSN
Copy link
Contributor Author

@smoelius. Thank you!

@YanVictorSN YanVictorSN deleted the feature-path-upgrade-optional branch February 4, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoelius smoelius Awaiting requested review from smoelius smoelius is a code owner

Assignees
No one assigned
Labels
requires release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the path argument to cargo dylint upgrade optional
3 participants
@YanVictorSN @CLAassistant @smoelius