Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stylesheets recipe #896

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Add stylesheets recipe #896

merged 4 commits into from
Jan 30, 2024

Conversation

albarivas
Copy link
Contributor

What does this PR do?

Adds a recipe for the new stylesheets feature, and moves styling recipes to their own tab

What issues does this PR fix or reference?

#

The PR fulfills these requirements:

[x] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@albarivas albarivas requested a review from a team as a code owner January 17, 2024 09:52
satyasekharcvb
satyasekharcvb approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@satyasekharcvb satyasekharcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider adding the test case for the stylesheet

@albarivas
Copy link
Contributor Author

You may consider adding the test case for the stylesheet

Tried our accessing the element styles through the DOM API property but they're not inherited from the CSS, so there's no way to test it

@albarivas albarivas merged commit dac83dd into main Jan 30, 2024
8 checks passed
@albarivas albarivas deleted the ar/stylesheets-recipe branch January 30, 2024 12:55
pozil pushed a commit that referenced this pull request Feb 8, 2024
@albarivas @pozil
Add stylesheets recipe (#896)
83e9416 
* Add stylesheets recipe

* Add tab to app

* Fix deploy

* Fix deploy
pozil added a commit that referenced this pull request Feb 13, 2024
@pozil @albarivas
@trailheadapps-bot @github-actions @dependabot @benjaminloerincz
Spring '24 release (#908)
57aa9d4 
* build: bump to API v60.0 (#898)

* Add stylesheets recipe (#896)

* Add stylesheets recipe

* Add tab to app

* Fix deploy

* Fix deploy

* Released new package version 04t3t000002YSCIAA4 (#899)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps-dev): bump prettier from 3.1.1 to 3.2.4

Bumps [prettier](https://github.com/prettier/prettier) from 3.1.1 to 3.2.4.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.1.1...3.2.4)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump eslint-plugin-jest from 27.6.1 to 27.6.3

Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.6.1 to 27.6.3.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.6.1...v27.6.3)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @lwc/eslint-plugin-lwc from 1.7.0 to 1.7.2

Bumps [@lwc/eslint-plugin-lwc](https://github.com/salesforce/eslint-plugin-lwc) from 1.7.0 to 1.7.2.
- [Release notes](https://github.com/salesforce/eslint-plugin-lwc/releases)
- [Commits](salesforce/eslint-plugin-lwc@v1.7.0...v1.7.2)

---
updated-dependencies:
- dependency-name: "@lwc/eslint-plugin-lwc"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump lint-staged from 15.2.0 to 15.2.1

Bumps [lint-staged](https://github.com/okonet/lint-staged) from 15.2.0 to 15.2.1.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Changelog](https://github.com/lint-staged/lint-staged/blob/master/CHANGELOG.md)
- [Commits](lint-staged/lint-staged@v15.2.0...v15.2.1)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @salesforce/sfdx-lwc-jest from 3.1.0 to 3.1.1

Bumps [@salesforce/sfdx-lwc-jest](https://github.com/salesforce/sfdx-lwc-jest) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/salesforce/sfdx-lwc-jest/releases)
- [Changelog](https://github.com/salesforce/sfdx-lwc-jest/blob/master/CHANGELOG.md)
- [Commits](salesforce/sfdx-lwc-jest@v3.1.0...v3.1.1)

---
updated-dependencies:
- dependency-name: "@salesforce/sfdx-lwc-jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump @sa11y/jest from 6.2.2 to 6.3.1

Bumps [@sa11y/jest](https://github.com/salesforce/sa11y/tree/HEAD/packages/jest) from 6.2.2 to 6.3.1.
- [Release notes](https://github.com/salesforce/sa11y/releases)
- [Changelog](https://github.com/salesforce/sa11y/blob/master/CHANGELOG.md)
- [Commits](https://github.com/salesforce/sa11y/commits/v6.3.1/packages/jest)

---
updated-dependencies:
- dependency-name: "@sa11y/jest"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* remove legacy if:true by lwc:if (#900)

* Released new package version 04t3t000002YSCcAAO (#909)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Alba Rivas <[email protected]>
Co-authored-by: Trailheadapps Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Lörincz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyasekharcvb satyasekharcvb satyasekharcvb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albarivas @satyasekharcvb