Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated D3 from 5.7.0 to 5.16.0 #351

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Updated D3 from 5.7.0 to 5.16.0 #351

merged 1 commit into from
Aug 7, 2020

Conversation

pozil
Copy link
Contributor

@pozil pozil commented Aug 3, 2020

No description provided.

@pozil pozil requested a review from pchittum August 3, 2020 11:40
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #351 into master will increase coverage by 11.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #351       +/-   ##
============================================
+ Coverage   88.94%   100.00%   +11.05%     
============================================
  Files          84         3       -81     
  Lines         615        20      -595     
  Branches       35         0       -35     
============================================
- Hits          547        20      -527     
+ Misses         66         0       -66     
+ Partials        2         0        -2     
Flag Coverage Δ
#Apex 100.00% <ø> (ø)
#LWC ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
force-app/main/default/lwc/chartBar/chartBar.js
force-app/main/default/lwc/mortgage/mortgage.js
...FormDynamicContact/recordViewFormDynamicContact.js
...-app/main/default/lwc/wireListView/wireListView.js
...ce-app/main/default/lwc/libsChartjs/libsChartjs.js
...n/default/lwc/helloExpressions/helloExpressions.js
...t/lwc/apexImperativeMethod/apexImperativeMethod.js
...reCurrentPageReference/wireCurrentPageReference.js
...tRecordStaticContact/wireGetRecordStaticContact.js
...default/lwc/wireGetRecordUser/wireGetRecordUser.js
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f455221...dc574d3. Read the comment docs.

@pchittum
Copy link
Contributor

pchittum commented Aug 7, 2020

Sorry for the delay. Just had to make time to stand up an org and test. 👍

@pozil
Copy link
Contributor Author

pozil commented Aug 7, 2020

No worries, thanks for the extra check.

@pozil pozil merged commit 70f4ec0 into master Aug 7, 2020
@pozil pozil deleted the pozil/d3-update branch August 7, 2020 11:49
jmcaudron pushed a commit to jmcaudron/lwc-recipes that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants