Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic working test #343

Merged
merged 1 commit into from
Jul 28, 2020
Merged

basic working test #343

merged 1 commit into from
Jul 28, 2020

Conversation

pchittum
Copy link
Contributor

This adds a basic test to the miscPermissionsBasedUI component. We can expand on it later.

#340

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #343 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   88.45%   88.94%   +0.48%     
==========================================
  Files          84       84              
  Lines         615      615              
  Branches       35       35              
==========================================
+ Hits          544      547       +3     
+ Misses         69       66       -3     
  Partials        2        2              
Flag Coverage Δ
#Apex 100.00% <ø> (ø)
#LWC 88.57% <ø> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lwc/miscPermissionBasedUI/miscPermissionBasedUI.js 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b446ad7...8c7f96e. Read the comment docs.

@pchittum
Copy link
Contributor Author

Also fixed the info text formatting in the markup.

@pchittum pchittum requested a review from pozil July 27, 2020 10:00
@pchittum pchittum merged commit c81b3f1 into master Jul 28, 2020
@pchittum pchittum deleted the pc/perm-mod-fix branch July 28, 2020 08:57
<strong>Access_Restricted_UI</strong> permission set to this user
and refresh the page.
rendered UI assign
the&nbsp;<strong>Access_Restricted_UI</strong>&nbsp;permission set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion to avoid hard-coding escape characters would be to use the prettier-ignore comment option on the outer div, see example implementation here.

jmcaudron pushed a commit to jmcaudron/lwc-recipes that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants