Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TESTING.md to account for changes in behavior #790

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

jnoordsij
Copy link
Collaborator

What does this PR do?

Update testing docs:

  • Specify Docker as requirement
  • Remove clause with old dependencies from unit testing section
  • Fix typo

Motivation

When testing for #789, I noticed the TESTING.md file seems outdated. I'm not sure if my changeset covers all changes, but I think it changes the most important parts for those trying to run tests.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

- Specify Docker as requirement
- Remove clause with old dependencies from unit testing section
- Fix typo
Copy link
Member

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we missed it.
Thanks @jnoordsij !

@mloiseleur mloiseleur added area/documentation Improvements or additions to documentation status/3-needs-merge labels Feb 13, 2023
@traefiker traefiker merged commit e4a15d8 into traefik:master Feb 13, 2023
@jnoordsij jnoordsij deleted the update-testing-docs branch February 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants