Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Disabling dashboard ingressroute should delete it #785

Merged
merged 1 commit into from
Feb 10, 2023
Merged

🐛 Disabling dashboard ingressroute should delete it #785

merged 1 commit into from
Feb 10, 2023

Conversation

mloiseleur
Copy link
Member

@mloiseleur mloiseleur commented Feb 10, 2023

What does this PR do?

Set dashboard IngressRoute as a regular helm resource instead of a hook.
Forced to make a new PR from #668 : I was unable to update it.

Motivation

It's not needed anymore to install it with a hook.
Fixes #115

If you see during upgrade this message

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. 
Unable to continue with update: IngressRoute "traefik-dashboard" in namespace "default" exists and cannot be imported into the current release: invalid ownership metadata;
annotation validation error: missing key "meta.helm.sh/release-name": must be set to "traefik"; 
annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"

That means you were on Traefik Helm Chart in version < 15.2.1 and tried to upgrade directly to latest version.
You'll need to upgrade to at least v15.2.1 before upgrading to latest version.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed
  • Is there a way to avoid break during upgrade between hook version and regular version ?

@mloiseleur mloiseleur added kind/bug/fix kind/breaking This PR introduce a breaking change labels Feb 10, 2023
@mloiseleur mloiseleur merged commit 55615b9 into traefik:master Feb 10, 2023
@mloiseleur mloiseleur deleted the fix/ingressroute branch February 10, 2023 10:04
terrych0u pushed a commit to terrych0u/traefik2-helm-chart that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking This PR introduce a breaking change kind/bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling dashboard ingressroute does not delete it
2 participants