💥 Rename image.name => image.repository #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in fact a repository path and it's needed for Renovate compatibility
|
Friends, Its not just a rename, This broke our production system. |
|
@juanitoddd when releasing we follow semver. We released this by incrementing a major version (X.0.0), this means it will include breaking changes. |
terrych0u
pushed a commit
to terrych0u/traefik2-helm-chart
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename helm value from
image.nametoimage.repositoryIt's just a renaming, no change on the behaviour.
Motivation
It's in fact a repository path and it's needed for Renovate compatibility.
See #625 & renovatebot/renovate#7010
More
make testand all the tests passed