Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👔 Improve labels settings behavior on metrics providers #774

Merged
merged 1 commit into from
Jan 3, 2023
Merged

👔 Improve labels settings behavior on metrics providers #774

merged 1 commit into from
Jan 3, 2023

Conversation

mloiseleur
Copy link
Member

@mloiseleur mloiseleur commented Dec 28, 2022 •
edited
Loading

What does this PR do?

It's improving addRoutersLabels, addServicesLabels and addEntryPointsLabels options with the following:

  1. When set to false, it's add a "=false" CLI arg
  2. When set to true, it's add a "=true" CLI arg
  3. When not set, it's not set.

Motivation

Behavior is more clear and expected. It fixes #770

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Additional Notes

In current Helm versions, nil | toString return <nil> instead of "" or nil.

@mloiseleur mloiseleur mentioned this pull request Dec 28, 2022
Closed
2 tasks
@mloiseleur mloiseleur merged commit 6e34825 into traefik:master Jan 3, 2023
@mloiseleur mloiseleur deleted the fix/metrics_options branch January 3, 2023 09:53
terrych0u pushed a commit to terrych0u/traefik2-helm-chart that referenced this pull request Oct 2, 2023
@mloiseleur @terrych0u
👔 Improve labels settings behavior on metrics providers (traefik#774)
f868eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-haley charlie-haley charlie-haley approved these changes

Assignees
No one assigned
Labels
kind/bug/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some options for metrics seem to be hardcoded not allowing to modification through values
2 participants
@mloiseleur @charlie-haley