-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CRDs-schema): add global
and enabled
placeholders for subchart/dependency
#1348
base: master
Are you sure you want to change the base?
feat(CRDs-schema): add global
and enabled
placeholders for subchart/dependency
#1348
Conversation
@mloiseleur Especially interested to hear your take on this as I know you are involved in #1334 and have not provided a specific opinion on #1331 yet |
@ArlonAntonius I guess you mean on #1311 . We can add required properties from some use cases and keep the benefits of the schema. FYI, the schema is generated from values: Lines 30 to 35 in 6350cb1
Would you please update your PR accordingly, so the schema will be kept ? |
@mloiseleur Made the required changes, let me know if this aligns correctly with Traefik's coding and documentation standards 😉 |
@ArlonAntonius See my suggestion for improved documentation. Otherwise, LGTM. |
global
and enabled
placeholders for subchart/dependency
Co-authored-by: Michel Loiseleur <[email protected]>
@mloiseleur Included your change 🚀 Any chance we can include this in the release you have planned in #1351 ? |
@ArlonAntonius You need to rebase this PR (and/or allow edit from maintainers) |
What does this PR do?
Fixes #1311
Superseeds #1334
TL:DR Allows the usage of the traefik-crds chart as a subchart/dependency.
Motivation
To use the traefik-crds Helm Chart as a dependency in your projects, the validation needs to be slightly looser to support the usage of the chart. Helm passes specific values by default (
global
in this case), causing the Schema Validation to give an error.In line with other Helm Charts (like cert-manager), it would be beneficial to allow users to set:
global
to fix the error that will always be caused by Helm passing theglobal
valuesenabled
to provide users with the default (recommended) flag for conditions on Helm ChartsThe one thing that I did, that is more opinionated and would like the opinion of Traefik's maintainer on is the usage of
additionalProperties
on theglobal
object. Cert-manager specifically provides a set of variables, defeating part of the feature's purpose (in my opinion).https://github.com/cert-manager/cert-manager/blob/23d3aea079ce88cec6f9394f4a4027720f8d7c2a/deploy/charts/cert-manager/values.schema.json#L686
More
make test
and all the tests passed